Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-5021 - fixed place order for custom shipping methods with under… #18689

Merged
merged 1 commit into from
Oct 27, 2018
Merged

ISSUE-5021 - fixed place order for custom shipping methods with under… #18689

merged 1 commit into from
Oct 27, 2018

Conversation

idziakjakub
Copy link
Contributor

@idziakjakub idziakjakub commented Oct 18, 2018 •
edited
Loading

…score in carrier code

This fix allows to add custom shipping method with underscore in custom carrier code.

Description (*)

This fix avoid problem with incorrect shipping method code when logged in customer want to place order using custom shipping method with underscore in carrier code or method.
Issue was reproduced on versions:

  • 2.1.9
  • 2.2.5
  • 2.3

Fixed Issues (if relevant)

  1. "Please specify a shipping method" Exception #5021: "Please specify a shipping method" Exception

Manual testing scenarios (*)

  1. Create custom shipping method module with underscore '_' in carrier code eg. "custom_shipping"
  2. Enable custom shipping method
  3. Create account and log in
  4. Add product to cart
  5. Go to checkout and select custom shipping method
  6. Place order

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 18, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @idziakjakub. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nuzil nuzil self-assigned this Oct 19, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 22, 2018
@nuzil nuzil self-requested a review October 23, 2018 08:47
nuzil
nuzil approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@nuzil nuzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-3237 has been created to process this Pull Request

@sidolov sidolov mentioned this pull request Oct 27, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 9688034 into magento:2.3-develop Oct 27, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 27, 2018
ENGCOM-3237: ISSUE-5021 - fixed place order for custom shipping metho…
9c67298 
…ds with under… #18689
@magento-engcom-team
Copy link
Contributor

Hi @idziakjakub. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@gelanivishal gelanivishal mentioned this pull request Oct 27, 2018
Merged
4 tasks
@hostep hostep mentioned this pull request Jan 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuzil nuzil nuzil approved these changes

Assignees

@nuzil nuzil

Labels
Award: bug fix Component: Checkout Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@idziakjakub @magento-cicd2 @magento-engcom-team @nuzil